fetch-metadata: remove tokio #1822
Closed
+21
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Oct 14, 2024
jsdw
reviewed
Oct 14, 2024
| @@ -29,6 +29,7 @@ quote = { workspace = true } | |||
| subxt-codegen = { workspace = true, features = ["fetch-metadata"] } | |||
| scale-typegen = { workspace = true } | |||
| polkadot-sdk = { workspace = true, optional = true, features = ["sp-io", "sc-executor-common", "sp-state-machine", "sp-maybe-compressed-blob", "sc-executor"] } | |||
| futures = { workspace = true, features = ["executor"] } | |||
There was a problem hiding this comment.
I guess one reason for tokio was just that it was already likely to be included as a dep. I wonder if this adds any new deps to the tree or whether it was also in use somewhere anyways?
There was a problem hiding this comment.
EDIT: It will bring in futures-executor/futures-task which is small and it should be much more lite-weight than tokio rt and it compiles for WASM
If one brings in futures with the default features this is already enabled and most likely already enabled for most cases I think...
jsdw
approved these changes
Oct 14, 2024
niklasad1
commented
Oct 14, 2024
niklasad1
commented
Oct 14, 2024
|
after thinking about this, if one doesn't use tokio then creating jsonrpsee::ws_client this will panic so I think it safer to keep tokio anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's worth to use tokio in fetch-metadata for the blocking API and I removed in favor if futures::executor::block_on